Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid Reforge ID's #14

Closed
stako opened this issue Jun 1, 2024 · 0 comments
Closed

Invalid Reforge ID's #14

stako opened this issue Jun 1, 2024 · 0 comments

Comments

@stako
Copy link

stako commented Jun 1, 2024

After importing my WSE string into the WowSims website, I noticed that one of my reforges was incorrect.

I have reforged this item's Expertise into Haste.

image

Export String: {"id":59223,"gems":[52212],"reforging":167,"enchant":3222}
Note the reforge ID of 167 - this ID is for Mastery into Haste

I believe the issue lies in the GetItemCurrentStats function. In this case, the function has returned a value of '10' for mastery - matching the item's socket bonus. May need some logic to avoid parsing socket bonuses, similar to the current logic that it's using to avoid parsing enchants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant