Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add +Weapon Skill tooltip parsing #127

Closed
kayla-glick opened this issue Feb 7, 2024 · 4 comments · Fixed by #214
Closed

Add +Weapon Skill tooltip parsing #127

kayla-glick opened this issue Feb 7, 2024 · 4 comments · Fixed by #214

Comments

@kayla-glick
Copy link
Collaborator

Right now our tooltip parser is missing regexes to capture +Weapon Skill effects.

https://github.com/wowsims/sod/blob/master/tools/database/wowhead_tooltips.go

@rosenrusinov
Copy link
Contributor

@kayla-glick We dont do Weapon Skill with Reg-ex because its much more involved. We do it with NewItemEffects in the common/sod code. You can find examples in there I think in the melee_items.go

@kayla-glick
Copy link
Collaborator Author

Aah ok so it's done on an item-by-item basis then?

@Foknetics
Copy link
Contributor

Foknetics commented Feb 8, 2024

Started to implement this for Bonk-Maestro's Handguards and Power-Assisted Lifting Belt but realized the current ApplyWeaponSpecialization ref is not handling the difference between one hand and two hand. This is fine for the racials (because they cover both 1h and 2h), and fine for the dagger skill on the gnomer set (because there is no 2h daggers) but not usable for the two new items.

	// Bonk-Maestro's Handguards
	core.NewItemEffect(213278, func(agent core.Agent) {
		character := agent.GetCharacter()

		character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeFist)
		character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeMace)
	})
	
	// Power-Assisted Lifting Belt
	core.NewItemEffect(215380, func(agent core.Agent) {
		character := agent.GetCharacter()

		character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeAxe)
		character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeSword)
		character.ApplyWeaponSpecialization(3, proto.WeaponType_WeaponTypeMace)
	})

@TheGroxEmpire
Copy link
Contributor

I'm working on fixing weapon skills. It'll be overhauled completely.

@TheGroxEmpire TheGroxEmpire linked a pull request Feb 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants