Skip to content

Commit

Permalink
fix necrosis metrics (#3095)
Browse files Browse the repository at this point in the history
  • Loading branch information
lime-green committed May 17, 2023
1 parent e72a443 commit ec459c2
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions sim/deathknight/talents_unholy.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,19 +112,15 @@ func (dk *Deathknight) necrosisOHAuto(sim *core.Simulation, target *core.Unit, s
spell.BonusWeaponDamage()

if result := spell.CalcAndDealDamage(sim, target, baseDamage, spell.OutcomeMeleeWhite); result.Damage > 0 {
dk.Necrosis.SpellMetrics[target.UnitIndex].Hits++
dk.Necrosis.SpellMetrics[target.UnitIndex].Casts++
dk.Necrosis.CalcAndDealDamage(sim, target, result.Damage*dk.NecrosisCoeff, spell.OutcomeAlwaysHit)
dk.Necrosis.CalcAndDealDamage(sim, target, result.Damage*dk.NecrosisCoeff, dk.Necrosis.OutcomeAlwaysHit)
}
}
func (dk *Deathknight) necrosisMHAuto(sim *core.Simulation, target *core.Unit, spell *core.Spell) {
baseDamage := spell.Unit.MHWeaponDamage(sim, spell.MeleeAttackPower()) +
spell.BonusWeaponDamage()

if result := spell.CalcAndDealDamage(sim, target, baseDamage, spell.OutcomeMeleeWhite); result.Damage > 0 {
dk.Necrosis.SpellMetrics[target.UnitIndex].Hits++
dk.Necrosis.SpellMetrics[target.UnitIndex].Casts++
dk.Necrosis.CalcAndDealDamage(sim, target, result.Damage*dk.NecrosisCoeff, spell.OutcomeAlwaysHit)
dk.Necrosis.CalcAndDealDamage(sim, target, result.Damage*dk.NecrosisCoeff, dk.Necrosis.OutcomeAlwaysHit)
}
}

Expand Down

0 comments on commit ec459c2

Please sign in to comment.