Balance fixes #1501
Merged
Balance fixes #1501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes look good to me. Since testing done in JamminL/cata-classic-bugs#66 implies that Starfire has a higher proc chance than Wrath, and Aggrend's comment doesn't disagree ("Its core data is to proc 3.5 times per minute"): are you planning to update that part, too? |
Gashiraa
force-pushed
the
balance-fixes
branch
from
c8c3b73
to
00e3f6b
Compare
vigo2
requested changes
Oct 29, 2022
Gashiraa
force-pushed
the
balance-fixes
branch
2 times, most recently
from
3d158c0
to
2a3c462
Compare
Gashiraa
force-pushed
the
balance-fixes
branch
3 times, most recently
from
b77061b
to
566aeb2
Compare
vigo2
approved these changes
Oct 31, 2022
vigo2
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
After gathering more test data, I'm pretty sure Hurricane's chance to proc OOC is slightly higher (I had 705 procs in 45985 casts, or 1.53%), so there's more test results disagreeing with Aggrend's developer quote.
But that's all rather academical ;)
Oh, and if possible: please don't force push, I didn't even notice you had updated the PR.
Gashiraa
force-pushed
the
balance-fixes
branch
from
566aeb2
to
ef6746f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.