ui: change demonic pact raid buff value meaning #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tharre
force-pushed
the
ui_fixes
branch
4 times, most recently
from
d120569
to
3243fc0
Compare
Previously, you'd set the amount equal to 10 times what you wanted the demonic pact to be, with the reasoning that DP is 10% of the respective warlocks spellpower. However this is problmatic for several reasons: - DP is actually more than 10% on first application (11%) - The ingame buff shows the SP amount - For the demo sim we show average DP again as the actual SP amount By limiting this value to 1000, it should be self-evident for users how it works now, since most will want to sim with DP values of at least 200, which would translate to a value of 2000 in the old way, which can no longer be set. Fixes wowsims#2807.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, you'd set the amount equal to 10 times what you wanted the demonic pact to be, with the reasoning that DP is 10% of the respective warlocks spellpower. However this is problmatic for several reasons:
By limiting this value to 1000, it should be self-evident for users how it works now, since most will want to sim with DP values of at least 200, which would translate to a value of 2000 in the old way, which can no longer be set.
Fixes #2807.