Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Multi-Target Ignoring Blade Flurry #3100

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix Multi-Target Ignoring Blade Flurry #3100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions sim/rogue/talents.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -516,6 +516,12 @@ func (rogue *Rogue) registerBladeFlurryCD() {
Type: core.CooldownTypeDPS,
Priority: core.CooldownPriorityDefault,
ShouldActivate: func(sim *core.Simulation, character *core.Character) bool {

if rogue.Rotation.MultiTargetSliceFrequency == proto.Rogue_Rotation_Never {
// Well let's just cast BF now, no need to optimize around slices that will never be cast
return true
}

if sim.GetRemainingDuration() > cooldownDur+dur {
// We'll have enough time to cast another BF, so use it immediately to make sure we get the 2nd one.
return true
Expand Down