Authentication happening if no auth header is sent. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…null for json_basic_auth_error; right now if basic auth isnt used we just assume the user is authenticated even if no authentication method has been used.
|
Good catch, thanks! |
rmccue
added a commit
that referenced
this pull request
Sep 8, 2014
Authentication happening if no auth header is sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If basic auth is used, we need to return null for json_basic_auth_error. Right now, if basic auth isn't used, we just assume the user is authenticated even if no authentication method has been used.
To confirm this bug, view /posts/?context=edit (without sending a nonce) while the Basic Auth plugin is enabled. You will see posts when you shouldn't.