Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle deferrer script loading #61

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Handle deferrer script loading #61

merged 1 commit into from
Nov 7, 2023

Conversation

MeliEve
Copy link
Contributor

@MeliEve MeliEve commented Nov 7, 2023

Hi guys,

I made a small change in the loading of the plugin because I have to do the js loading deferred due to bad score in PageSpeed Insights (in my case I am deferring it with the Hummingbird plugin) and it was not working for me that way, everything went to spam.
I made a pull request with the changes that worked for me, I hope that's okay.

Regards

@erikyo erikyo self-requested a review November 7, 2023 19:24
@erikyo erikyo merged commit f23fa9e into wp-blocks:main Nov 7, 2023
13 checks passed
@erikyo
Copy link
Collaborator

erikyo commented Nov 7, 2023

Thank you @MeliEve, thank you for catching this! With @gardenboi we are working on releasing a new version very soon, will obviously include this improvement. thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants