Follow WPs PHP documentation standards #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
IanDelMar
commented
Nov 14, 2019
IanDelMar
commented
- Single line comments
- Multi-line comments
- No period for file headers
- Capitalize first letter
* Single line comments - https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#5-1-single-line-comments * Multi-line comments - https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/#5-2-multi-line-comments * Capitalize first letter
mikaykun
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Checked against rules on https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/php/
Everything is fine.
pattonwebz
approved these changes
Nov 18, 2019
|
@mikaykun thank you for checking this and verifying that it is ok. I also quickly scanned it and seems ok so I am happy to merge this in :) @IanDelMar thank you for this one, good change. I will look at the other PRs later today when I get a bit of free time :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.