Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping supported version #22

Closed
szepeviktor opened this issue Dec 10, 2017 · 8 comments
Closed

Bumping supported version #22

szepeviktor opened this issue Dec 10, 2017 · 8 comments

Comments

@szepeviktor
Copy link
Contributor

When a plugin author bumps supported core version in readme.txt we get "Checksum does not match"

@shawnhooper
Copy link
Contributor

+1 My test results are returning Checksum does not match on 3 plugins' readme.txt files.

@danielbachhuber
Copy link
Member

@szepeviktor @shawnhooper Can you share which plugins are impacted by this?

@schlessera Maybe we should only Warning: when readme.txt differs?

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Dec 11, 2017

Maybe we should only Warning: when readme.txt differs?

Yes.

If a plugin author knows of this trick then readme will change outside releases.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Dec 11, 2017

Can you share which plugins are impacted by this?

For example wp-postratings and classic-smilies

@shawnhooper
Copy link
Contributor

Can you share which plugins are impacted by this?

advanced-custom-fields, duplicate-post, and google-drive-embedder on the site I tested with.

@schlessera
Copy link
Member

@eriktorsner had included the concept of "soft changes" in his implementation: https://github.com/eriktorsner/wp-checksum/blob/6ed1a5ea5fb77f418a4abaf27795626ade75c863/src/PluginChecker.php#L22-L24

I'd suggest using the same approach, ignoring soft changes, while optionally allowing strict checks through an additional parameter.

@schlessera
Copy link
Member

The "soft change" functionality was now added.

readme.txt changes should now be ignored unless you specify the --strict flag.

@szepeviktor
Copy link
Contributor Author

szepeviktor commented Dec 14, 2017

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants