Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --config-file argument to process custom configuration files #104

Merged
merged 15 commits into from Jan 6, 2022
Merged

Add --config-file argument to process custom configuration files #104

merged 15 commits into from Jan 6, 2022

Conversation

pmbaldha
Copy link
Contributor

@pmbaldha pmbaldha commented Mar 16, 2020 •
edited by schlessera

@pmbaldha pmbaldha requested a review from a team as a code owner March 16, 2020 10:21
@pmbaldha pmbaldha mentioned this pull request Mar 16, 2020
Closed
1 task
@schlessera
Copy link
Member

@pmbaldha Can you add Behat tests to this PR?

@pmbaldha
Copy link
Contributor Author

@schlessera I have written all related behat tests.

@pmbaldha pmbaldha closed this Mar 30, 2020
@pmbaldha pmbaldha reopened this Mar 30, 2020
schlessera
schlessera requested changes Apr 1, 2020
View reviewed changes
features/config-delete.feature Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
src/Config_Command.php Outdated Show resolved Hide resolved
schlessera
schlessera requested changes Apr 1, 2020
View reviewed changes
Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is mostly good, just needs a refactor for get_config_path() method. Most of the other issues are about whitespace.

@pmbaldha pmbaldha requested a review from schlessera April 2, 2020 15:09
@schlessera schlessera changed the title Add --config-file argument - Custom wp-config.php file parameter for wp config Add --config-file argument to process custom configuration files Apr 8, 2020
@schlessera schlessera force-pushed the 20200312_PB_--config-file_param_introduced branch from 79cd5b4 to 352ea08 Compare December 24, 2021 01:19
@schlessera schlessera force-pushed the 20200312_PB_--config-file_param_introduced branch from 352ea08 to 0770824 Compare December 24, 2021 01:23
@schlessera schlessera force-pushed the 20200312_PB_--config-file_param_introduced branch from bb51322 to 5da390f Compare January 6, 2022 01:03
@schlessera schlessera added this to the 2.1.2 milestone Jan 6, 2022
@schlessera schlessera force-pushed the 20200312_PB_--config-file_param_introduced branch from 5da390f to b3f05ca Compare January 6, 2022 01:11
@schlessera schlessera merged commit 1e39424 into wp-cli:master Jan 6, 2022
schlessera added a commit that referenced this pull request Jan 6, 2022
@schlessera
Merge pull request #104 from pmbaldha/20200312_PB_--config-file_param…
02926ad 
…_introduced
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
command:config
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

Custom wp-config.php file parameter for wp config set command
2 participants
@pmbaldha @schlessera