Make the config command consistent by providing "list" and "get".

[schlessera]

To make the wp config command more consistent with the way the rest of the commands behave, and to add needed functionality, I renamed the current wp config get command (which displays a list of all values) into wp config list, and added a new wp config get <key> command to retrieve the value of a specific key.

This allows one to use something like wp config get table_prefix to quickly get one particular value.

[danielbachhuber]

👎

I patterned wp config get after wp post get, which displays all fields.

The established pattern is:

• wp * list is for listing a collection of objects.
• wp * get is for getting an individual object.
• wp * get --field=<field> is for getting the value of a specific field.

[schlessera]

Well, the problem is that wp * get --field=<field> does not work as expected. The collection of objects is the collection of variables/constants here.

If you do wp * get --field=<field>, <field> is the column, meaning key, value or type. That is mostly useless.

There's no way to fetch a single value right now.

[schlessera]

Just try getting the table_prefix... :)

[danielbachhuber]

Sure, it's not implemented yet. We could add this pattern: wp config get --global=table_prefix or wp config get --constant=DB_NAME

[schlessera]

If you model it as described above, it is meant to manage a "collection of wp-config.php files", which is not logical. And a single "item" is all of the contents of one wp-config.php file.

So, to compare posts vs configs...

Your approach:
list => collection of posts, collection of wp-config.php files
get => single post, single wp-config.php file
get --field => single post column, single wp-config.php file value

My approach:
list => collection of posts, collection of wp-config.php entries
get => single post, single wp-config.php entry
get --field => single post column, unneeded as a wp-config.php entry only has one column

[danielbachhuber]

If you model it as described above, it is meant to manage a "collection of wp-config.php files", which is not logical. And a single "item" is all of the contents of one wp-config.php file.

"Not logical" is your opinion. If you consider Configuration as an abstract entity where a Configuration contains a variety of globals and constants, then it is a logical model.

Furthermore, and more importantly, my model is consistent with the rest of WP-CLI, meaning there's no mental overhead when using it.

get => single post, single wp-config.php entry
get --field => single post column, unneeded as a wp-config.php entry only has one column

This wouldn't work, because globals and constants can have the same name. You'd always need a --type=<type> clarifier.

[schlessera]

I rather meant "not intuitive". I know a bit about WP-CLI, but I have spent 10 minutes trying to figure out how to get the table_prefix. :) I was just assuming that wp config get would get me a config value, not the entire config.

[danielbachhuber]

Furthermore, we already have wp config create, which creates an entire wp-config.php file, not an individual value, and wp config path, which provides the path to the wp-config.php file.

I know a bit about WP-CLI, but I have spent 10 minutes trying to figure out how to get the table_prefix. :) I was just assuming that wp config get would get me a config value, not the entire config.

Sure, let's add support for getting individual values.