Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use die() when there is a db error #166

Merged
merged 1 commit into from Oct 20, 2023
Merged

Do not use die() when there is a db error #166

merged 1 commit into from Oct 20, 2023

Conversation

swissspidy
Copy link
Member

This is a follow-up to #158

Using die() makes debugging super hard and caused me quite a headache with wp-cli/wp-cli-tests#187

@swissspidy swissspidy added this to the 2.3.2 milestone Oct 20, 2023
@swissspidy swissspidy requested a review from a team as a code owner October 20, 2023 08:18
@swissspidy swissspidy mentioned this pull request Oct 20, 2023
Merged
@swissspidy
Copy link
Member Author

The failing tests are only the known SQLite ones

@swissspidy swissspidy merged commit 9de6ce3 into main Oct 20, 2023
32 of 41 checks passed
@swissspidy swissspidy deleted the no-time-to-die branch October 20, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
bug command:config-create
Projects
None yet
Milestone
2.3.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swissspidy @danielbachhuber