Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for SQLite #168

Merged
merged 4 commits into from Nov 1, 2023
Merged

Fix tests for SQLite #168

merged 4 commits into from Nov 1, 2023

Conversation

swissspidy
Copy link
Member

@swissspidy swissspidy commented Oct 23, 2023 •
edited

  • Provide --skip-check to wp config create everywhere
  • Add a new dedicated test covering --skip-check
  • Rename wp core config to wp config create in tests so it’s less confusing
  • Remove some errant whitespace here in some commands

See #167

@swissspidy
Fix tests for SQLite
13a9c06 
- Provide `—skip-check` to `wp config create` everywhere
- Add a new dedicated test covering `—skip-check`
- Rename `wp core config` to `wp config create` in tests so it’s less confusing
- Remove some errant whitespace here in some commands
@swissspidy swissspidy requested a review from a team as a code owner October 23, 2023 14:23
@swissspidy swissspidy mentioned this pull request Oct 23, 2023
Open
@swissspidy swissspidy added this to the 2.3.3 milestone Oct 26, 2023
@danielbachhuber danielbachhuber merged commit c2a04ca into main Nov 1, 2023
41 checks passed
@danielbachhuber danielbachhuber deleted the fix/167-sqlite branch November 1, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
scope:testing
Projects
None yet
Milestone
2.3.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@swissspidy @danielbachhuber