Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect message shuffling salt in PHP 5.6 #176

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix incorrect message shuffling salt in PHP 5.6 #176

merged 2 commits into from
Mar 1, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Feb 20, 2024 •
edited by danielbachhuber
Loading

Fixes #175

danielbachhuber
danielbachhuber reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a new test or adjust an existing test for this scenario?

@ernilambar ernilambar marked this pull request as ready for review February 21, 2024 07:49
@ernilambar ernilambar requested a review from a team as a code owner February 21, 2024 07:49
@ernilambar
Copy link
Member Author

@danielbachhuber PR has been updated.

@danielbachhuber danielbachhuber changed the title Fix duplicate warning Fix incorrect message shuffling salt in PHP 5.6 Mar 1, 2024
@danielbachhuber danielbachhuber added this to the 2.3.4 milestone Mar 1, 2024
@danielbachhuber danielbachhuber merged commit 445dfd0 into wp-cli:main Mar 1, 2024
36 checks passed
@ernilambar ernilambar deleted the 175-warning-duplicate branch March 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
bug command:config command:config-shuffle-salts
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.

Incorrect message shuffling salt in PHP 5.6
2 participants
@ernilambar @danielbachhuber