Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve messaging when shuffling salts #177

Merged

Conversation

ernilambar
Copy link
Member

Fixes #173

  • If no keys are passed, original success message Shuffled the salt keys. will be displayed.
  • Utils\report_batch_operation_results() is used to display message when keys are passed.

@ernilambar ernilambar requested a review from a team as a code owner March 1, 2024 07:00
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement, thank you @ernilambar !

$ wp config shuffle-salts
Success: Shuffled the salt keys.
$ wp config shuffle-salts SECURE_AUTH_KEY
Success: Shuffled 1 of 1 salts.
$ wp config shuffle-salts SECURE_AUTH_KEYSSS
Warning: Could not shuffle the unknown key 'SECURE_AUTH_KEYSSS'.
$ wp config shuffle-salts SECURE_AUTH_KEY SECURE_AUTH_KEYSSS
Warning: Could not shuffle the unknown key 'SECURE_AUTH_KEYSSS'.
Success: Shuffled 1 of 2 salts (1 skipped).

@danielbachhuber danielbachhuber added this to the 2.3.4 milestone Mar 1, 2024
@danielbachhuber danielbachhuber changed the title Fix message in shuffle salts Improve messaging when shuffling salts Mar 1, 2024
@danielbachhuber danielbachhuber merged commit 76ffc92 into wp-cli:main Mar 1, 2024
36 checks passed
@ernilambar ernilambar deleted the 173-fix-shuffle-salt-message branch March 17, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve message for config shuffle-salts result
2 participants