New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup for `--skip-content` flag #40

Merged
merged 5 commits into from Oct 2, 2017

Conversation

3 participants
@danielbachhuber
Member

danielbachhuber commented Oct 1, 2017

  • Cleanup tests for greater specificity.
  • Move errors to an earlier position to prevent unnecessary code execution.
  • Use the appropriate cache key name for --skip-content.
  • Avoid duplicate API requests by executing code path earlier.

Fixes #36

@danielbachhuber danielbachhuber added this to the 1.0.3 milestone Oct 1, 2017

@danielbachhuber danielbachhuber requested a review from wp-cli/committers Oct 1, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 1, 2017

Member

@AaronRutley ^ Worth looking through those changes to see the cleanup I did.

Member

danielbachhuber commented Oct 1, 2017

@AaronRutley ^ Worth looking through those changes to see the cleanup I did.

@AaronRutley

This comment has been minimized.

Show comment
Hide comment
@AaronRutley

AaronRutley Oct 2, 2017

@danielbachhuber! I've just had a look over your cleanup commits, it all makes sense, thanks!

AaronRutley commented Oct 2, 2017

@danielbachhuber! I've just had a look over your cleanup commits, it all makes sense, thanks!

@schlessera schlessera merged commit e3ae26e into master Oct 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the 36-cleanup branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment