Allow operation without .distignore file #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continue execution without a .distignore, and warn users all files will be included.
swissspidy
reviewed
May 20, 2022
| Scenario: Warns but continues when no distignore file is present | ||
| Given an empty directory | ||
| And a test-plugin.php file: | ||
| """ |
There was a problem hiding this comment.
Note that you're mixing spaces with tabs here multiple times
There was a problem hiding this comment.
Sorry, looks like it's spaces I should be using. I'd run phpcbf but hasn't considered the test.
|
Looks like a reasonable change 👍 |
schlessera
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue execution where there is no
.distignorepresent.Warn users all files will be included.
My general use has been a plugin wholly contained in a project sub-directory (#42, #45) so has no need for a .distignore.