Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for adding and removing of multiple user roles #437

Merged

Conversation

shawnhooper
Copy link
Contributor

Fixes: #423
Related: wp-cli/wp-cli#5859

@shawnhooper shawnhooper requested a review from a team as a code owner November 10, 2023 22:24
src/User_Command.php Show resolved Hide resolved
src/User_Command.php Show resolved Hide resolved
features/user.feature Outdated Show resolved Hide resolved
@shawnhooper
Copy link
Contributor Author

@danielbachhuber Ok, requested changes made and tests passing locally. Ready for re-review.

Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more tweaks, then should be good

features/user.feature Outdated Show resolved Hide resolved
features/user.feature Outdated Show resolved Hide resolved
src/User_Command.php Outdated Show resolved Hide resolved
src/User_Command.php Outdated Show resolved Hide resolved
@danielbachhuber danielbachhuber changed the title Implement adding and removing of multiple user roles Support for adding and removing of multiple user roles Nov 10, 2023
@danielbachhuber danielbachhuber added this to the 2.5.7 milestone Nov 10, 2023
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@danielbachhuber danielbachhuber merged commit b5846bf into wp-cli:main Nov 10, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple roles in user add-role and user remove-role
2 participants