Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --use-include flag #64

Merged
merged 7 commits into from Dec 8, 2022
Merged

Add --use-include flag #64

merged 7 commits into from Dec 8, 2022

Conversation

kozer
Copy link
Contributor

@kozer kozer commented Dec 8, 2022 •
edited by danielbachhuber

Fixes #49

@kozer kozer requested a review from a team as a code owner December 8, 2022 12:15
danielbachhuber
danielbachhuber reviewed Dec 8, 2022
View reviewed changes
src/EvalFile_Command.php Outdated Show resolved Hide resolved
src/EvalFile_Command.php Outdated Show resolved Hide resolved
@danielbachhuber danielbachhuber changed the title Add --use-incude flag Add --use-include flag Dec 8, 2022
@danielbachhuber danielbachhuber added this to the 2.2.0 milestone Dec 8, 2022
schlessera
schlessera previously requested changes Dec 8, 2022
View reviewed changes
Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks only, the code looks good.

src/EvalFile_Command.php Outdated Show resolved Hide resolved
src/EvalFile_Command.php Outdated Show resolved Hide resolved
src/EvalFile_Command.php Outdated Show resolved Hide resolved
danielbachhuber and others added 3 commits December 8, 2022 13:02
@danielbachhuber @schlessera
Fix misaligned indentation
2344004 
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@danielbachhuber @schlessera
Improve parameter comment
ab8d0c0 
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@danielbachhuber @schlessera
Improve argument comment
d565a80 
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
@danielbachhuber danielbachhuber merged commit fc1c994 into wp-cli:main Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

@schlessera schlessera schlessera left review comments

Assignees

@kozer kozer

Labels
command:eval-file
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

Add --use-include flag in order to overcome eval() limitations
3 participants
@kozer @danielbachhuber @schlessera