Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add theme status in `wp theme get` command #177

Merged
merged 5 commits into from Jun 5, 2019

Conversation

@sagarnasit
Copy link
Contributor

commented May 22, 2019

Add theme status filed for wp theme get command.

Fixes #172

@sagarnasit sagarnasit requested a review from wp-cli/committers as a code owner May 22, 2019

@thrijith
Copy link
Member

left a comment

Thanks for the PR @sagarnasit !

Could please add tests for this change?

@sagarnasit

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

@thrijith added a behat test

@thrijith
Copy link
Member

left a comment

@sagarnasit, Thanks for the PR !

I've added a few comments regarding the tests, rest LGTM, I think it should also contain one test for wp theme get p2 with status row in it.

features/theme.feature Outdated Show resolved Hide resolved
features/theme.feature Outdated Show resolved Hide resolved
@sagarnasit

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

@thrijith Added changes you asked.

features/theme.feature Outdated Show resolved Hide resolved
@sagarnasit

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

Not sure why the build is failing, It seems unrelated to this PR.

@schlessera

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@sagarnasit Can you merge/rebase latest master? I think the test failure should be fixed now.

@thrijith thrijith merged commit 7b4d477 into wp-cli:master Jun 5, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera added this to the 2.0.6 milestone Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.