Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some tests for SQLite #378

Merged
merged 2 commits into from Nov 4, 2023
Merged

Update some tests for SQLite #378

merged 2 commits into from Nov 4, 2023

Conversation

swissspidy
Copy link
Member

Partially addresses #377. Some scenarios still need updating though.

@swissspidy swissspidy linked an issue Oct 23, 2023 that may be closed by this pull request
SQLite Compatibility #377
Closed
@swissspidy swissspidy added this to the 2.1.16 milestone Oct 26, 2023
@swissspidy
Copy link
Member Author

Unfortunately there are no logs for the actual "Run Behat" step where the issue with the SQLite tests happens.

@swissspidy swissspidy marked this pull request as ready for review November 2, 2023 13:27
@swissspidy swissspidy requested a review from a team as a code owner November 2, 2023 13:27
danielbachhuber
danielbachhuber approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems kinda suboptimal to duplicate all of these tests 🙃

I don't have a better suggestion at this time, though.

@danielbachhuber danielbachhuber merged commit 19f45ab into main Nov 4, 2023
41 checks passed
@danielbachhuber danielbachhuber deleted the fix/377-sqlite branch November 4, 2023 12:43
@swissspidy swissspidy mentioned this pull request Nov 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees
No one assigned
Labels
scope:testing
Projects
None yet
Milestone
2.1.16
Development

Successfully merging this pull request may close these issues.

SQLite Compatibility
2 participants
@swissspidy @danielbachhuber