Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing docblock for activate_language() #46

Closed
schlessera opened this issue Aug 6, 2018 · 1 comment
Closed

Missing docblock for activate_language() #46

schlessera opened this issue Aug 6, 2018 · 1 comment
Labels
bug command:language-core

Comments

@schlessera
Copy link
Member

The Core_Language_Command class contains a public method activate_language() that does not come with the needed docblock: https://github.com/wp-cli/language-command/blob/v2.0.0/src/Core_Language_Command.php#L321

This throws a warning in the debug output:

Debug (commandfactory): No doc comment for activate_language. (0.086s)
D

As this method is not meant to be a possible command, it should not be public.
@schlessera schlessera mentioned this issue Aug 10, 2018
Merged
@swissspidy
Copy link
Member

Fixed by #47.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug command:language-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@schlessera @swissspidy