Fix path returned from get_composer_json_path under Windows #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @davgothic ! Test failures are unrelated, so going ahead and landing this. If you want to make another contribution, I think we'd be better off with a utility function in |
schlessera
pushed a commit
that referenced
this pull request
Jan 5, 2022
Fix path returned from get_composer_json_path under Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows operating systems the
$HOMEenvironment variable may not be defined leading to this package attempting to create the composer package directory under/.wp-cli/packages/composer.jsonwhich fails:This fix will attempt to create the home path from
$HOMEDRIVEand$HOMEPATHenvironment variables if$HOMEis empty.