Revert composer.json on memory limit error. #64
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27.
Deals with PHP memory allocation failure on install/uninstall corrupting the WP-CLI packages
composer.json
by registering a shutdown function to revert to backup.Adds 2 new helper functions
get_composer_json_path_backup_decoded()
, which reads and validatescomposer.json
, andregister_revert_shutdown_function()
.Modifies the
get_composer_json_path()
andcreate_default_composer_json()
functions to return the absolute path of thecomposer.json
file to simplify use, and adds some error checking and usesUtils
.Also unrelatedly puts try/catch processing into
get_composer()
to simplify use, and removes redundant call inuninstall()
, and calls once outside loop inshow_packages()
.Adds phpunit tests for the new
get_composer_json_path_backup_decoded()
function and the modifiedget_composer_json_path()
andcreate_default_composer_json()
functions.Needs wp-cli/wp-cli#4597 and a scaffold package-tests refresh before merging to use
{INVOKE_WP_CLI_WITH_PHP_ARGS-}
.