Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent warnings in PHP 8.2 when $col_values is empty #160

Merged
merged 1 commit into from
Jul 21, 2023
Merged

Prevent warnings in PHP 8.2 when $col_values is empty #160

merged 1 commit into from
Jul 21, 2023

Conversation

danielbachhuber
Copy link
Member

@danielbachhuber danielbachhuber commented Jul 20, 2023 •
edited

Fixes #159

Note: you'll need to resize your browser window in order to trigger the error warnings.

$  wp post create --post_title="Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy eirmod tem por por por"
$ wp post list

@danielbachhuber danielbachhuber added this to the 0.11.19 milestone Jul 20, 2023
@danielbachhuber danielbachhuber self-assigned this Jul 20, 2023
@danielbachhuber danielbachhuber requested a review from a team as a code owner July 20, 2023 16:32
@danielbachhuber danielbachhuber mentioned this pull request Jul 20, 2023
Closed
@danielbachhuber danielbachhuber merged commit 2d27f0d into master Jul 21, 2023
31 checks passed
@danielbachhuber danielbachhuber deleted the fix/prevent-warning-php-8-2 branch July 21, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees

@danielbachhuber danielbachhuber

Labels
bug
Projects
None yet
Milestone
0.11.19
Development

Successfully merging this pull request may close these issues.

PHP 8.2 deprecation: ASCII renderer with empty row values.
2 participants
@danielbachhuber @swissspidy