Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move command over to new v2 structure #151

Merged
merged 24 commits into from
Sep 25, 2018
Merged

Move command over to new v2 structure #151

merged 24 commits into from
Sep 25, 2018

Conversation

wojsmol
Copy link
Contributor

@wojsmol wojsmol commented Aug 10, 2018 •
edited

fixes #150

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 11, 2018 •
edited

@GaryJones Plese take a look on phpcs errors here and give me a hint how to solve them.

GaryJones
GaryJones reviewed Aug 11, 2018
View reviewed changes
phpcs.xml.dist Outdated

<!-- For help in understanding this testVersion:
https://github.com/PHPCompatibility/PHPCompatibility#sniffing-your-code-for-compatibility-with-specific-php-versions -->
<config name="testVersion" value="5.3-"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to 5.4- - that will remove a few violations from being reported.

@GaryJones
Copy link

Variable variables can typically be fixed by making $$key into ${$key} though I've not looked at the logic in this package.

Reported violations about siliencing errors, and eval, if it's right for them to be ignored, can be hidden by the use of the // phpcs:ignore Name.Of.Sniff.Error -- for reasons-format comment on the same line as the violation, or as the only comment on the line before it.

@wojsmol
Copy link
Contributor Author

wojsmol commented Aug 12, 2018

https://travis-ci.org/wp-cli/profile-command/jobs/414874921 - this is php 7.2 incompatibility
https://travis-ci.org/wp-cli/profile-command/jobs/414874922 and others to proper table produced.

@schlessera schlessera added this to the 2.0.0 milestone Aug 21, 2018
@schlessera schlessera changed the title convert to v2 Move command over to new v2 structure Aug 21, 2018
@schlessera schlessera merged commit dadade7 into wp-cli:master Sep 25, 2018
@wojsmol wojsmol deleted the tov2 branch September 25, 2018 18:32
@schlessera schlessera modified the milestones: 2.0.0, 0.4.0 Dec 17, 2018
@wojsmol wojsmol mentioned this pull request Jun 5, 2019
Closed
2 tasks
danielbachhuber pushed a commit that referenced this pull request Nov 18, 2022
@schlessera
Merge pull request #151 from wojsmol/tov2
e560986 
Move command over to new v2 structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryJones GaryJones GaryJones left review comments

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
scope:distribution
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

Move command over to new v2 structure
3 participants
@wojsmol @GaryJones @schlessera