Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: all private methods now protected #328

Closed
wants to merge 1 commit into from

Conversation

benjamingrolleau
Copy link

Related issue : #327

I've just replaced all private methods by protected methods. We can now extend Scaffold_Command easily.

@benjamingrolleau benjamingrolleau requested a review from a team as a code owner January 26, 2024 10:39
@danielbachhuber
Copy link
Member

Thanks for the PR, @benjamingrolleau !

If we make these methods protected, then we're making a contract with the package consumer and have to worry about backwards-compat breaks, etc. (unlikely as it is).

Generally, when we do offer utilities, we explicitly indicate them as such, e.g. https://make.wordpress.org/cli/handbook/references/internal-api/

You're welcome to copy whatever code you'd like into your project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants