Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds wildcards support to `--skip-tables` parameter #124

Merged
merged 2 commits into from Jul 24, 2019

Conversation

@ajoah
Copy link

commented Jul 19, 2019

This little PR permits to use wildcards in skip-tables option like this : --skip-tables=wp_post*.

Useful for example when we want to skip a plugin's tables which begin by a prefix

@ajoah ajoah requested a review from wp-cli/committers as a code owner Jul 19, 2019

@schlessera

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Thanks for the PR, @ajoah !

Code looks generally good, I just want to have positive matches added to tests as well, otherwise an empty output would still let the tests pass.

@ajoah

This comment has been minimized.

Copy link
Author

commented Jul 24, 2019

You are right, i'm going to modify my PR.

Aurélien Joahny

@schlessera schlessera added this to the 2.0.4 milestone Jul 24, 2019

@schlessera schlessera merged commit 2872f04 into wp-cli:master Jul 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Thanks for the PR, @ajoah !

@schlessera schlessera changed the title Adds wildcards support to skip-tables parameter Adds wildcards support to `--skip-tables` parameter Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.