Use empty string default value for flags to safeguard the use of explode()
#169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soean
approved these changes
Oct 17, 2022
|
We have ran into the same issue, this change should fix the problem. @schlessera How can we help here to get the problem fixed? |
schlessera
approved these changes
Oct 17, 2022
schlessera
force-pushed
the
cjhaas-php81-null-to-explode
branch
from
8aef9f5
to
f5bad04
Compare
schlessera
changed the title
explode()
danielbachhuber
pushed a commit
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PHP 8.1 deprecation warning for passing
nulltoexplode.See #168 for more details