Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try removing "ignore-platform-reqs" from Dependencies.yml #72

Merged
merged 1 commit into from Feb 6, 2019

Conversation

@danielbachhuber
Copy link
Member

commented Feb 6, 2019

From #71

@danielbachhuber danielbachhuber referenced this pull request Feb 6, 2019

@danielbachhuber danielbachhuber requested a review from schlessera Feb 6, 2019

@danielbachhuber danielbachhuber added this to the 2.2.0 milestone Feb 6, 2019

@danielbachhuber

This comment has been minimized.

Copy link
Member Author

commented Feb 6, 2019

Going ahead and landing this so we can see what the impact is tomorrow.

@danielbachhuber danielbachhuber merged commit 73134ad into master Feb 6, 2019

2 checks passed

DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the danielbachhuber-patch-1 branch Feb 6, 2019

@schlessera

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

That actually did seem to do the trick... not sure why, though.

@danielbachhuber

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

@schlessera For the same reason running composer update locally doesn't break the Phar. Our specific platform requirements are only used to compute the dependency graph.

@schlessera

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Sure, but that means my first interpretation of --ignore-platform-reqs was correct after all and was actually breaking the Phar.

@danielbachhuber

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

that means my first interpretation of --ignore-platform-reqs was correct after all and was actually breaking the Phar.

I don't understand. Can you explain further?

@danielbachhuber

This comment has been minimized.

Copy link
Member Author

commented Feb 7, 2019

Oh, I think I understand what you're saying. Your original statement around including --ignore-platform-reqs was that doing so would break the Phar. If this is the case, then yes, this is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.