Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress trunk is causing framework test to fail #4694

Closed
danielbachhuber opened this issue Feb 19, 2018 · 2 comments
Closed

WordPress trunk is causing framework test to fail #4694

danielbachhuber opened this issue Feb 19, 2018 · 2 comments
Labels
scope:framework scope:testing
Milestone
2.0.0

Comments

@danielbachhuber
Copy link
Member

See screenshot:

image

Affecting #4692
@danielbachhuber
Copy link
Member Author

Might be caused by https://core.trac.wordpress.org/changeset/42716/

@gitlost
Copy link
Contributor

gitlost commented Feb 19, 2018

Yes! just tracked this down to this recent change https://core.trac.wordpress.org/ticket/42299 in trunk which gets around a bug in WP_Site_Query::query() that doesn't ignore domain__in when given empty arg and which will probably be properly addressed by https://core.trac.wordpress.org/ticket/42252

Have PR ready!...

@gitlost gitlost mentioned this issue Feb 19, 2018
Merged
@schlessera schlessera added this to the 2.0.0 milestone Feb 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scope:framework scope:testing
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@danielbachhuber @schlessera @gitlost