Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt WP_CLI_CS across the wp-cli organization #5179

Closed
27 tasks done
schlessera opened this issue Apr 20, 2019 · 6 comments
Closed
27 tasks done

Adopt WP_CLI_CS across the wp-cli organization #5179

schlessera opened this issue Apr 20, 2019 · 6 comments
Milestone

Comments

@schlessera
Copy link
Member

schlessera commented Apr 20, 2019

All wp-cli repos should be adapted to use and enfore the new WP_CLI_CS PHPCS code standard.

Progress

Up for grabs

Every bundled command is completed.

In progress

Every bundled command is completed.

Completed

Related #5192

@schlessera schlessera added this to the 2.2.0 milestone Apr 20, 2019
@jrfnl
Copy link
Contributor

jrfnl commented Apr 22, 2019

I have a suspicion that there are still some repos missing from the above list. Is there a specific reason why these were excluded from this ticket ?

@thrijith
Copy link
Member

thrijith commented Apr 22, 2019

@jrfnl I think the list only contains repos that are part of wp-cli-bundle. I am not sure about the reason for exclusion though.

@jrfnl
Copy link
Contributor

jrfnl commented Apr 22, 2019

@thrijith ... which then begs the question why the above listed commands are not part of the bundle ? 😃

@thrijith
Copy link
Member

The WP-CLI GitHub organization contains all project code repositories. Some commands are bundled with WP-CLI, while others are independently installable. Commands are bundled with WP-CLI when they’re stable, closely aligned with the project philosophy, and useful to a majority of users.

Ref: https://make.wordpress.org/cli/handbook/governance/#how-does-all-of-this-work

I think this should answer your question. 😄

@schlessera
Copy link
Member Author

There are multiple possible reasons why they might not be bundled:

  • abandoned, but then moved over to WP-CLI for long-term maintenance
  • not mature enough
  • only contextually useful

We will hoist everything we can to the new CS, but only the bundled commands are relevant for the release deadline, hence the prioritisation.

@schlessera
Copy link
Member Author

This is fixed for all bundled commands and completes the requirements for the v2.2.0 release.

Work on non-bundled packages will be tracked in #5201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants