Get tests passing again in all repositories

[danielbachhuber]

We have a lot of automated test failures right now. Let's get them passing again!

Done is:

• Automated tests are passing in all repositories.

[swissspidy]

Now that wp-cli/.github#61 has been merged, let's re-run some tests to see if they still fail now.

Some are now already passing again, so that's great 🎉

Note: Some packages (e.g. widget-command, package-command, maintenance-mode-command, language-command, embed-command) haven't run tests in a while, so we need to push some changes to trigger a run

➡️ #58673 is a common issue across many packages. It will be resolved hopefully before RC. No action needed from our side!

wp-cli/scaffold-command

Still some failures:

• Scenario: Install WordPress from trunk (in general)
  • Caused by #58673
• Scenario: Install WordPress from trunk (on PHP 5.6 + WP latest)
  • Needs a @require-php-7.0 tag

wp-cli/profile-command

• Scenario: Error when SAVEQUERIES is defined to false
  • Caused by #58673

wp-cli/db-command

• Scenario: Clean up a WordPress install without dropping its database entirely but tables with prefix
  • Caused by #58673

[wojsmol]

Note: Some packages (e.g. widget-command, package-command, maintenance-mode-command, language-command, embed-command) haven't run tests in a while, so we need to push some changes to trigger a run

For this re-enabiling a testing workflow will be enough.

[swissspidy]

Note: Some packages (e.g. widget-command, package-command, maintenance-mode-command, language-command, embed-command) haven't run tests in a while, so we need to push some changes to trigger a run

For this re-enabiling a testing workflow will be enough.

We tested it earlier and I was not able to re-run tests after re-enabling the workflows because the runs were too old (more than 90 days). See for example https://github.com/wp-cli/maintenance-mode-command/actions/workflows/testing.yml

[wojsmol]

@swissspidy After re-enabling https://github.com/wp-cli/maintenance-mode-command/blob/5d51793771c3d927ef9c501b527ea42d30c9838c/.github/workflows/testing.yml#L9-L10 should work Manual run is not allowed for testing workflow.

To at least receive notification when a repo is stale we can use https://github.blog/2023-06-05-announcing-the-stale-repos-action/ in a wp-cli/dashbord repo

[swissspidy]

@wojsmol That's not what I meant, I was referring to this button which is missing in those cases:

But yeah I'll just wait for the next test to be triggered.

[swissspidy]

wp-cli/core-command (run)

• 001 Example: | trunk | When I run wp core update --version=trunk
• Example: | nightly | When I run wp core update --version=nightly
• 003 Scenario: Installing latest nightly build should skip cache

These should all get @require-php-7.0

wp-cli/automated-tests

• Do not test WP trunk on PHP 5.6 automated-tests#36

---

I think that's it. We can go through all of them again once that bug in core is fixed.

[swissspidy]

wp-cli/search-replace-command (run)

• 001 Scenario: Run on all tables matching string with wildcard
  • This one seems to cause an exception on trunk. Needs further investigating.

[swissspidy]

This fix in trunk should resolve most failures now: https://core.trac.wordpress.org/changeset/56226

[danielbachhuber]

Tagged some releases and submitted an update to the bundle wp-cli/wp-cli-bundle#559

[swissspidy]

So far it's looking really good!

search-replace-command still needs looking into: https://github.com/wp-cli/search-replace-command/actions/runs/5538237598/jobs/10118012114

In the automated-tests repo embed-command is now failing when trying to do wp embed provider match https://asciinema.org/a/140798. Tests passed in the embed-command repo itself though yesterday. But I don't know why.

asciinema.org is not an allowlisted oEmbed provider in WordPress and does not oEmbed meta tags to its web pages. Maybe they just removed that recently? In that case we would need to update tests to use different URLs.

media-command: the tests were disabled, I just re-enabled the workflow.

This test appears to be failing as it tries to upgrade to trunk on PHP 5.6:

https://github.com/wp-cli/media-command/blob/0334b288f123861714029c843d1ea9410ebb7f27/features/media-regenerate.feature#L1214-L1226

Any ideas?

[danielbachhuber]

search-replace-command still needs looking into: https://github.com/wp-cli/search-replace-command/actions/runs/5538237598/jobs/10118012114

Seems to be some collision with a new core option in trunk. I tweaked the test with wp-cli/search-replace-command#185

In the automated-tests repo embed-command is now failing when trying to do wp embed provider match https://asciinema.org/a/140798. Tests passed in the embed-command repo itself though yesterday. But I don't know why.

Yeah, let's swap with a different provider.

This test appears to be failing as it tries to upgrade to trunk on PHP 5.6:

https://github.com/wp-cli/media-command/blob/0334b288f123861714029c843d1ea9410ebb7f27/features/media-regenerate.feature#L1214-L1226

We can skip the test because it's only applicable to PHP 5.6: wp-cli/media-command#179

[swissspidy]

Fix for the embed command:

• Replace asciinema.org in tests embed-command#71

[swissspidy]

The dashboard is all green now! 🎉

[danielbachhuber]

Thanks for your work on this, @swissspidy ! 🙌