Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce reset subcommand for widget #3077

Merged
merged 7 commits into from Jun 30, 2016
Merged

Introduce reset subcommand for widget #3077

merged 7 commits into from Jun 30, 2016

Conversation

ernilambar
Copy link
Contributor

@ernilambar ernilambar commented Jun 29, 2016

Initially at #3063, reset was supposed to be kept under sidebar. But after #3071 reset feature is kept under widget command.

Fixes #3063

@@ -305,6 +305,81 @@ public function delete( $args, $assoc_args ) {
}

/**
* Reset sidebar.
*
* Removes all widgets from the sidebar and place those to Inactive Widgets.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "place those to" to "places them in"

@ernilambar
Copy link
Contributor Author

@danielbachhuber build error seems due to tochange in comment in trunk. Should I restart the build?

@danielbachhuber
Copy link
Member

build error seems due to tochange in comment in trunk. Should I restart the build?

Merge master to include #3076 and it will be fixed

@ernilambar ernilambar closed this Jun 30, 2016
@ernilambar ernilambar reopened this Jun 30, 2016
@ernilambar
Copy link
Contributor Author

Finally All checks have passed. 😄

@danielbachhuber danielbachhuber added this to the 0.24.0 milestone Jun 30, 2016
@danielbachhuber danielbachhuber merged commit 2241b8a into wp-cli:master Jun 30, 2016
@ernilambar ernilambar deleted the introduce-reset-for-widget branch June 30, 2016 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants