Bail early on add_command().
#4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As Composer will use a fixed require for any package files included in the Composer autoloader's `"files"` directive, we need to bail early in the `WP_CLI::add_command()` method so that WP-CLI is not executed from web-requests where it was included in the same `composer.json` file than the WP code itself. See #4124
danielbachhuber
approved these changes
Jun 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Composer will use a fixed require for any package files included in the Composer autoloader's
"files"directive, we need to bail early in theWP_CLI::add_command()method so that WP-CLI is not executed from web-requests where it was included in the samecomposer.jsonfile than the WP code itself.See #4124