Speed up vagrant scheme calls by caching vagrant ssh-config
#5235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This improves handling for
vagrant
scheme by caching the output ofvagrant ssh-config
, and using values within to convert the call to use the standardssh
scheme.This helps speed up sample requests up to 3 seconds ( ie: sometimes 700% ) in all calls.
Before:
After:
Also fixed handling of
vagrant
connection URL so it behaves more consistently with the rest of connection types.Fun irrelevant realization I couldn't resist to share: Shaving a minute a day off a developer's time, multiplied by 22 days a month, equals 22 minutes, multiplied by 30 developers a company, equals 11 hours a month, which is more than a billable day for agencies! And that doesn't even include the cost of interruptions!