Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use has_config() in get_config() to prevent warnings on null values #5880

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Use has_config() in get_config() to prevent warnings on null values #5880

merged 3 commits into from
Dec 13, 2023

Commits on Nov 21, 2023

  1. In get_config(), use has_config() to test for key existence instead o… 

    …f equivelent isset() which throws a warning for null values.

A null value can occur if the option is present, but without a value. Certain config values, such as --url, default to null causing has_config() to be true, while throwing a warning in get_config(). This change provides consistency between has_config() and get_config().
    @dougaxe1
    dougaxe1 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ccf4e47 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Add test for null config value in get_config

    @dougaxe1
    dougaxe1 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    8ae1d35 View commit details
    Browse the repository at this point in the history

  2. Remove trailing space in test

    @dougaxe1
    dougaxe1 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    a83b6e6 View commit details
    Browse the repository at this point in the history