Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded compatibility shim #5885

Merged
merged 2 commits into from Dec 8, 2023
Merged

Remove unneeded compatibility shim #5885

merged 2 commits into from Dec 8, 2023

Conversation

schlessera
Copy link
Member

As WP-CLI now has a minimum PHP requirement of PHP 5.6+, we don't need the PHP 5.4 compatibility shim anymore for the UpgraderSkin class.

This was initially introduced in #5283 .

@schlessera schlessera requested a review from a team as a code owner December 8, 2023 10:34
@schlessera schlessera added this to the 2.10.0 milestone Dec 8, 2023
@schlessera schlessera merged commit 8d05c78 into main Dec 8, 2023
65 checks passed
@schlessera schlessera deleted the fix/remove-unneeded-compat branch December 8, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
scope:framework
Projects
None yet
Milestone
2.10.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@schlessera @swissspidy