Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent missing file extensions from throwing errors #5947

Closed
wants to merge 1 commit into from
Closed

Prevent missing file extensions from throwing errors #5947

wants to merge 1 commit into from

Commits on May 8, 2024

  1. Prevent missing file extensions from throwing errors 

    Some file URL do not include the common .zip extension and therefore are missing their extension when reaching the `import` method of `FileCache`.

This issue is commonly seen with Premium plugins which use a custom URL to provide access to a keyed download file.

Running `wp plugin update <name of premium plugin>` was throwing a "Warning: copy(-<version>.): Failed to open stream: Permission denied". 

Instead of assuming the extension is valid nor trying to guess the extension is `.zip` simply bypass the storing of cache when the extension is not available.
    @lipemat
    lipemat committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9a262f9 View commit details
    Browse the repository at this point in the history