Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EOF as special-case anchor #23

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Add EOF as special-case anchor #23

merged 1 commit into from
Jul 23, 2019

Conversation

fuegas
Copy link
Contributor

@fuegas fuegas commented Jun 20, 2019

This is a fix for #10. However, instead of using

[ 'anchor' => WPConfigTransformer::NO_ANCHOR ]

I suggest to use

[ 'anchor' => WPConfigTransformer::ANCHOR_EOF ]

With this name you know where it will be placed right away.

@fuegas fuegas requested a review from a team as a code owner June 20, 2019 10:10
@schlessera schlessera added this to the 1.2.6 milestone Jul 23, 2019
@schlessera
Copy link
Member

Thanks for the PR, @fuegas !

@schlessera schlessera merged commit 1ca9834 into wp-cli:master Jul 23, 2019
@schlessera schlessera changed the title Add a way to add to EOF Add EOF as special-case anchor Jul 23, 2019
@schlessera schlessera mentioned this pull request Jul 23, 2019
Closed
@schlessera schlessera mentioned this pull request Aug 14, 2019
Closed
@fuegas fuegas deleted the support-anchor-eof branch September 23, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlessera schlessera schlessera approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.2.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fuegas @schlessera