Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EOF as special-case anchor #23

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@fuegas
Copy link
Contributor

commented Jun 20, 2019

This is a fix for #10. However, instead of using

[ 'anchor' => WPConfigTransformer::NO_ANCHOR ]

I suggest to use

[ 'anchor' => WPConfigTransformer::ANCHOR_EOF ]

With this name you know where it will be placed right away.

@fuegas fuegas requested a review from wp-cli/committers as a code owner Jun 20, 2019

@fuegas fuegas force-pushed the fuegas:support-anchor-eof branch from 7dcb41c to d66b625 Jun 20, 2019

@schlessera schlessera added this to the 1.2.6 milestone Jul 23, 2019

@schlessera

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

Thanks for the PR, @fuegas !

@schlessera schlessera merged commit 1ca9834 into wp-cli:master Jul 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title Add a way to add to EOF Add EOF as special-case anchor Jul 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.