Remove deprecated notice and add preload command

[iandunn]

No description provided.

[iandunn]

Err, I should have made separate branches for those and submitted them individually. Let me know if you want to just accept one or the other and I'll do that.

[scribu]

A single PR is fine in this case.

Question: why do you schedule a cron job instead of calling the hook directly?

[iandunn]

wp_cron_preload_cache() runs in batches, caching 100 items at a time, and then, if there are more items to process, it schedules another cron job in 30 seconds to run the next batch, and so on until it finishes processing all the items.

So, calling it directly would only do the first batch while the command is running, and the rest of the batches would still finish via cron.

Also, my use case for this is that I have a script that runs through all the domains in my hosting account and uses WP-CLI to upgrade Core/plugins/themes. I want to also flush and preload the cache for each domain after the upgrades run.

I figured if I call wp_cron_preload_cache() directly, it'd take 5-20 minutes per domain to finish preloading before moving on to the next domain, which doesn't really make sense in this context. I just want to kick off the process, and then move on.

I guess I could modify the command to call wp_cron_preload_cache() directly, then detect if there are more items and unschedule the job that it scheduled, then call it again, N times until it finishes, but that doesn't seem necessary or desirable to me. What do you think?

[scribu]

Ok, that makes sense. Merging.

[scribu]

To clarify, I mean that if you already have a system for doing it asynchronously, it doesn't make sense to make it blocking.

Thanks for the PR.

[iandunn]

No problem :)