Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch WSODs and provide a means for recovery for end users #3

Closed
wants to merge 73 commits into from
Closed

Catch WSODs and provide a means for recovery for end users #3

wants to merge 73 commits into from

Commits on Jul 30, 2018

  1. Port-over 44458.6.diff from Trac.

    Felix Arntz committed Jul 30, 2018
    Copy the full SHA
    bc7c925 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2018

  1. Merge branch 'master' into 44458

    @schlessera
    schlessera committed Aug 19, 2018
    Copy the full SHA
    e2621f2 View commit details
    Browse the repository at this point in the history

  2. Fix erroneous info in is_plaugin_paused() @return doc tag

    @schlessera
    schlessera committed Aug 19, 2018
    Copy the full SHA
    421ac71 View commit details
    Browse the repository at this point in the history

  3. Die with a 500 instead of a 200

    @schlessera
    schlessera committed Aug 19, 2018
    Copy the full SHA
    15a1dc2 View commit details
    Browse the repository at this point in the history

  4. Protect specific AJAX actions from WSODs

    @schlessera
    schlessera committed Aug 19, 2018
    Copy the full SHA
    e472c52 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2018

  1. Add multiple types of errors to be caught

    @schlessera
    schlessera committed Aug 20, 2018
    Copy the full SHA
    9ca6a03 View commit details
    Browse the repository at this point in the history

  2. Wrap the pluggable into a try/catch block

    @schlessera
    schlessera committed Aug 20, 2018
    Copy the full SHA
    128dca1 View commit details
    Browse the repository at this point in the history

  3. Adapt pluggable template handling

    @schlessera
    schlessera committed Aug 20, 2018
    Copy the full SHA
    80eee40 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2018

  1. Sandbox resuming a plugin to turn a new error into a dashboard notice… 

    … instead
    @schlessera
    schlessera committed Aug 21, 2018
    Copy the full SHA
    4852467 View commit details
    Browse the repository at this point in the history

  2. Extract endpoint criteria to protect into separate function

    @schlessera
    schlessera committed Aug 21, 2018
    Copy the full SHA
    fc7263a View commit details
    Browse the repository at this point in the history

  3. Fix typo in comment

    @schlessera
    schlessera committed Aug 21, 2018
    Copy the full SHA
    741f614 View commit details
    Browse the repository at this point in the history

  4. Add redirection on protected endpoints 

    When we are on a protected endpoint, we redirect to the same page after we paused a plugin.

This has two effects:

* The protected endpoints are always immediately available, they don't show the error message on first encounter.
* The flow is exactly the same, whether only one plugin or multiple plugins are broken. So, if you update PHP and ten plugins break at once, you still get into the admin backend with one click, and the ten plugins will be paused already.
    @schlessera
    schlessera committed Aug 21, 2018
    Copy the full SHA
    63ff519 View commit details
    Browse the repository at this point in the history

  5. Combine two conditionals

    @schlessera
    schlessera committed Aug 21, 2018
    Copy the full SHA
    0d3a399 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2018

  1. Merge branch 'master' into 44458

    @schlessera
    schlessera committed Aug 27, 2018
    Copy the full SHA
    f870c66 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2018

  1. Merge branch 'master' into 44458

    @schlessera
    schlessera committed Oct 1, 2018
    Copy the full SHA
    6341d89 View commit details
    Browse the repository at this point in the history

  2. Fix 'shutdownhandler.php' pluggable file name, which was missing th… 

    …e `.php` extension

Reported by @bradleyt in https://core.trac.wordpress.org/ticket/44458#comment:29
    @schlessera
    schlessera committed Oct 1, 2018
    Copy the full SHA
    d762d2e View commit details
    Browse the repository at this point in the history

  3. Still show custom error page if detected error cannot be persisted 

    Reported by @bradleyt in https://core.trac.wordpress.org/ticket/44458#comment:29
    @schlessera
    schlessera committed Oct 1, 2018
    Copy the full SHA
    dbe5bc0 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. Merge branch 'master' into 44458

    @felixarntz
    felixarntz committed Oct 2, 2018
    Copy the full SHA
    17a4bec View commit details
    Browse the repository at this point in the history

  2. Introduce filter to allow providing further protected endpoints.

    @felixarntz
    felixarntz committed Oct 2, 2018
    Copy the full SHA
    ffde485 View commit details
    Browse the repository at this point in the history

  3. Fix WP Coding Standards violations.

    @felixarntz
    felixarntz committed Oct 2, 2018
    Copy the full SHA
    8e69ea3 View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary function_exists() checks.

    @felixarntz
    felixarntz committed Oct 2, 2018
    Copy the full SHA
    e028d5e View commit details
    Browse the repository at this point in the history

  5. Move check for whether get_option() exists into wp_record_extension_e… 

    …rror().
    @felixarntz
    felixarntz committed Oct 2, 2018
    Copy the full SHA
    1fc6ea1 View commit details
    Browse the repository at this point in the history

  6. Move redirection logic for multiple errors above custom php-error.php… 

    … drop-in and clarify its usage.
    @felixarntz
    felixarntz committed Oct 2, 2018
    Copy the full SHA
    671d27a View commit details
    Browse the repository at this point in the history

  7. Fix typo.

    @felixarntz
    felixarntz committed Oct 2, 2018
    Copy the full SHA
    48c4b18 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2018

  1. Merge branch 'master' into 44458

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    20ed46d View commit details
    Browse the repository at this point in the history

  2. Update version numbers to 5.1.0.

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    7a9ac8e View commit details
    Browse the repository at this point in the history

  3. Allow regular administrators to resume a plugin in multisite.

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    1ca98a9 View commit details
    Browse the repository at this point in the history

  4. Skip loading network-active plugins that are paused.

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    ea160ac View commit details
    Browse the repository at this point in the history

  5. Do not handle MU-plugins as these should never be paused.

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    4a1e0e1 View commit details
    Browse the repository at this point in the history

  6. Introduce a simple class for storing paused extensions and store erro… 

    …rs in a multisite-friendly way.
    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    6637b5c View commit details
    Browse the repository at this point in the history

  7. Move essential error-protection functions to a new error-protection.p… 

    …hp file.
    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    fa7211f View commit details
    Browse the repository at this point in the history

  8. Fix bug with retrieving stored extension errors in multisite.

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    fe38caf View commit details
    Browse the repository at this point in the history

  9. Fix a possible PHP notice in the network admin.

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    bd8fae2 View commit details
    Browse the repository at this point in the history

  10. Adjust check in is_plugin_paused() to account for multisite.

    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    47d386b View commit details
    Browse the repository at this point in the history

  11. Introduce support for resuming plugins network-wide and displaying in… 

    …formation about the number of affected sites.
    @felixarntz
    felixarntz committed Oct 8, 2018
    Copy the full SHA
    3e8bfe7 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2018

  1. Merge branch 'master' into 44458

    @felixarntz
    felixarntz committed Dec 17, 2018
    Copy the full SHA
    4c02213 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2018

  1. Merge branch 'master' into 44458

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    3145368 View commit details
    Browse the repository at this point in the history

  2. Use plugin_sandbox_scrape() instead of rewriting identical functional… 

    …ity.
    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    7cbb4e3 View commit details
    Browse the repository at this point in the history

  3. Add missing is_site_meta_supported() check.

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    42b1205 View commit details
    Browse the repository at this point in the history

  4. Fix incorrect doc.

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    2c7810b View commit details
    Browse the repository at this point in the history

  5. Introduce method to retrieve a single paused extension error.

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    11b6deb View commit details
    Browse the repository at this point in the history

  6. Introduce function to retrieve active themes, filtering out paused th… 

    …emes, and use the logic to load functions.php in wp-settings.php.
    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    52aea23 View commit details
    Browse the repository at this point in the history

  7. Introduce wp_using_themes() function and filter it to false when them… 

    …es are paused.
    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    d7003fb View commit details
    Browse the repository at this point in the history

  8. Show an admin notice when a theme is paused.

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    fb60bea View commit details
    Browse the repository at this point in the history

  9. Add admin functions for detecting whether a theme is paused, retrievi… 

    …ng its error and querying sites by the theme being paused.
    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    d1cae9c View commit details
    Browse the repository at this point in the history

  10. Include error in theme instance when it is paused, so that it renders… 

    … as broken on Themes admin pages.
    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    ad88019 View commit details
    Browse the repository at this point in the history

  11. Introduce new capability to resume themes.

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    4f84f08 View commit details
    Browse the repository at this point in the history

  12. Allow resuming a paused theme.

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    489e43e View commit details
    Browse the repository at this point in the history

  13. Remove unused LIKE meta query that might cause headaches in the future.

    @felixarntz
    felixarntz committed Dec 27, 2018
    Copy the full SHA
    5220f85 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2018

  1. Replace echo sprintf occurrences with printf.

    @felixarntz
    felixarntz committed Dec 28, 2018
    Copy the full SHA
    54e9d0b View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2019

  1. Merge branch 'master' into 44458

    @felixarntz
    felixarntz committed Jan 7, 2019
    Copy the full SHA
    f147375 View commit details
    Browse the repository at this point in the history

  2. Introduce WP_Shutdown_Handler class for the WSOD protection and allow… 

    … overriding via a drop-in.
    @felixarntz
    felixarntz committed Jan 7, 2019
    Copy the full SHA
    851cfe7 View commit details
    Browse the repository at this point in the history

  3. Add two missing periods.

    @felixarntz
    felixarntz committed Jan 7, 2019
    Copy the full SHA
    9753e40 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2019

  1. Don't throw errors on missing constants

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    3809a1c View commit details
    Browse the repository at this point in the history

  2. Ensure passed-in $error information is valid

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    2b73834 View commit details
    Browse the repository at this point in the history

  3. Be extra safe with multisite load status

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    3061589 View commit details
    Browse the repository at this point in the history

  4. Revert "Be extra safe with multisite load status" 

    This reverts commit 3061589.
    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    bd47606 View commit details
    Browse the repository at this point in the history

  5. Change storage methods from set/unset to add/remove to avoid conflict… 

    … with the PHP unset keyword
    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    0a595a5 View commit details
    Browse the repository at this point in the history

  6. Remove unrelated translator comment additions which should go into a … 

    …separate ticket
    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    ea95b60 View commit details
    Browse the repository at this point in the history

  7. Make $extension argument for query clause required for now to avoid s… 

    …urprises
    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    885bae6 View commit details
    Browse the repository at this point in the history

  8. Prefer less precise isset() to array_key_exists() to match rest of code

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    6c63be1 View commit details
    Browse the repository at this point in the history

  9. Another safeguard for missing WP_CONTENT_DIR constant

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    9bfabcc View commit details
    Browse the repository at this point in the history

  10. Use stub for __() if it does not exist yet

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    0528ff5 View commit details
    Browse the repository at this point in the history

  11. Get rid of unneeded i18n method

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    e9f6b84 View commit details
    Browse the repository at this point in the history

  12. Reorder AJAX protected endpoint detection

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    f0c175e View commit details
    Browse the repository at this point in the history

  13. Add 'wp_protected_ajax_actions' filter

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    ce30fc3 View commit details
    Browse the repository at this point in the history

  14. Fix bug in isset logic

    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    c433600 View commit details
    Browse the repository at this point in the history

  15. Skip pausing of security-related plugins to avoid opening up an attac… 

    …k vector
    @schlessera
    schlessera committed Jan 9, 2019
    Copy the full SHA
    5d38162 View commit details
    Browse the repository at this point in the history

  16. Revert "Skip pausing of security-related plugins to avoid opening up … 

    …an attack vector"

This reverts commit 5d38162 as it
requires another discussion.
    @felixarntz
    felixarntz committed Jan 9, 2019
    Copy the full SHA
    489495f View commit details
    Browse the repository at this point in the history

  17. Rename WP_Paused_Extensions_Storage methods more accurately and adjus… 

    …t some docs.
    @felixarntz
    felixarntz committed Jan 9, 2019
    Copy the full SHA
    d9e59f9 View commit details
    Browse the repository at this point in the history

  18. Fix coding standards violation.

    @felixarntz
    felixarntz committed Jan 9, 2019
    Copy the full SHA
    d3ede87 View commit details
    Browse the repository at this point in the history

  19. Adjust translation strings to get rid of the term execution and match… 

    … existing labels in admin.
    @felixarntz
    felixarntz committed Jan 9, 2019
    Copy the full SHA
    9c078c1 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'master' into 44458

    @felixarntz
    felixarntz committed Jan 9, 2019
    Copy the full SHA
    ecfd731 View commit details
    Browse the repository at this point in the history