Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Version 3.6 #323

Merged
merged 46 commits into from
Oct 24, 2023
Merged

Create Version 3.6 #323

merged 46 commits into from
Oct 24, 2023

Conversation

NeilWJames
Copy link
Collaborator

This set of changes create a potentiala version 3.6 of the plugin.

I have created separate issues in the GitHub repository to describe further the changes made

#313, #314, #315, #316, #317, #318, #319, #320, #321 and #322.

They have all been addressed. The source of the changes are primarily due the Support requests received and answered, together with the change to WPCS 3.0.

NeilWJames and others added 30 commits March 1, 2023 00:24
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5.
- [Release notes](https://github.com/peter-evans/create-pull-request/releases)
- [Commits](peter-evans/create-pull-request@v4...v5)

---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…r-evans/create-pull-request-5

Bump peter-evans/create-pull-request from 4 to 5
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2023

Codecov Report

Merging #323 (c682641) into main (7d4157b) will decrease coverage by 0.51%.
The diff coverage is 55.23%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##               main     #323      +/-   ##
============================================
- Coverage     70.57%   70.07%   -0.51%     
- Complexity      864      901      +37     
============================================
  Files             9        9              
  Lines          3497     3639     +142     
============================================
+ Hits           2468     2550      +82     
- Misses         1029     1089      +60     
Flag Coverage Δ
multisite-0 69.90% <54.87%> (-0.67%) ⬇️
multisite-1 69.93% <54.94%> (?)
php- 70.07% <55.23%> (-0.51%) ⬇️
wp-5.1 64.58% <48.10%> (-0.87%) ⬇️
wp-latest 69.77% <54.87%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...cludes/class-wp-document-revisions-manage-rest.php 53.21% <16.66%> (ø)
includes/class-wp-document-revisions.php 59.22% <39.42%> (-2.00%) ⬇️
...class-wp-document-revisions-validate-structure.php 70.10% <46.66%> (-0.77%) ⬇️
includes/class-wp-document-revisions-front-end.php 88.70% <75.55%> (-1.11%) ⬇️
includes/class-wp-document-revisions-admin.php 66.54% <82.35%> (+1.12%) ⬆️
...-wp-document-revisions-recently-revised-widget.php 95.00% <83.33%> (-0.38%) ⬇️
wp-document-revisions.php 100.00% <100.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@benbalter benbalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NeilWJames, once again! I'm a little worried that such a large change in a single PR may introduce risk, especially as it touches on security logic, but appreciate the PR, and am supportive of the issues this addresses. Thanks!

@benbalter benbalter merged commit 2adc7c3 into wp-document-revisions:main Oct 24, 2023
10 checks passed
@NeilWJames
Copy link
Collaborator Author

@benbalter,
Thank you for progressing this.

You are certainly right.

I am currenly working on making the plugin WPML compliant. It is possible that there are a number of users who like the current user wants to have an English version and a German version of the document.

During my detailed tests of how WPML works, I see that I have created a small bug in the jpeg processing.

Please do not release the plugin yet.

Apologies for this error.
Neil James

NeilWJames added a commit to NeilWJames/wp-document-revisions that referenced this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants