Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable cache maps when "Use Object Cache" is disabled #230

Merged
merged 23 commits into from
Jul 14, 2023

Conversation

jasonbahl
Copy link
Collaborator

  • update testing workflow to test against WPGraphQL 1.14.4 (stop-gap as 1.14.5 had some changes that caused tests to break)
  • added Settings::cache_maps_enabled() to be able to check if cache maps are enabled. Default is the same as "caching_enabled()" but can be filtered to be different (i.e. plugins that don't want to use "local" cache, but do want to track the mapping)
  • Prevent maps from being built/stored if cache_maps are not enabled
  • add filter to tests to enable cache maps (tests currently rely on the maps)

closes #229

…as 1.14.5 had some changes that caused tests to break)

- added Settings::cache_maps_enabled() to be able to check if cache maps are enabled. Default is the same as "caching_enabled()" but can be filtered to be different (i.e. plugins that don't want to use "local" cache, but do want to track the mapping)
- Prevent maps from being built/stored if cache_maps are not enabled
- add filter to tests to enable cache maps (tests currently rely on the maps)
@jasonbahl jasonbahl added the bug Something isn't working label Jul 13, 2023
@jasonbahl jasonbahl self-assigned this Jul 13, 2023
@markkelnar markkelnar self-requested a review July 14, 2023 14:13
@jasonbahl jasonbahl merged commit fe967fc into main Jul 14, 2023
2 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cache Maps should not be stored if "Use Object Cache" setting is not enabled
2 participants