bug: do not cache mutations to object cache results #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add (failing) test for ensuring mutations are not cached
jasonbahl
reviewed
Jul 21, 2023
jasonbahl
reviewed
Jul 21, 2023
jasonbahl
reviewed
Jul 21, 2023
Co-authored-by: Jason Bahl <jasonbahl@mac.com>
Co-authored-by: Jason Bahl <jasonbahl@mac.com>
…ug-mutation-should-not-cache
…bug-mutation-should-not-cache
jasonbahl
changed the title
jasonbahl
reviewed
Jul 24, 2023
There was a problem hiding this comment.
@markkelnar per your question in Slack, if the test here seems valid and beneficial, let's pull it in. If it's a flaky test or otherwise unhelpful, we can close that PR and move on.
jasonbahl
requested changes
Jul 25, 2023
There was a problem hiding this comment.
@markkelnar I merged the PR that fixes the tests and then merged main back into this PR and tests are still failing.
I investigated a bit and thought I had found a bug where the filter was returning nothing instead of the default filtered value.
However this didn't fix the issue.
The BatchQueryTest is still failing.
|
@markkelnar I pushed up some more changes and got tests passing. |
jasonbahl
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When smart cache object cache is enabled to store results of queries, do not get/store mutation requests.
Fixes #196