Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wpengine specific code #247

Merged

Conversation

markkelnar
Copy link
Contributor

Remove the WP Engine specific code. This code exists in wpengine specific plugin, listening to the 'graphql_purge' action.

Dependent on wp-graphql change.

related to #246

@markkelnar
Copy link
Contributor Author

markkelnar commented Aug 10, 2023

Calling out the dependency on the wp-graphql or wpengine plugin.

The change in wp-graphql to use hostname as the URL cache header, means wpengine plugin purge hook that invalidates code on grapqhl_purge, will start working as the action that invalidates, instead of the smart-cache hook.

The only gap in functionality is if this smart-cache code is active (without the purge call to wpengine varnish with full https://hostname/path/) and older version of wp-graphql without the change above to hostname. In that situation graphql url header being used would include https://hostname/path but wpengine plugin would invalidate 'hostname' cache key. And cache would not invalidate.

Is it acceptable to document this and leave it up to the user to update versions of each to get/maintain cache invalidation behavior at wpengine?

@markkelnar markkelnar force-pushed the fix/remove-wpengine-explicit-purge branch from 3171a17 to 7fd742d Compare August 17, 2023 21:14
@markkelnar markkelnar merged commit fe9acaa into wp-graphql:main Aug 29, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants