ci: update tests to test against WordPress 6.4 #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephfusco
requested changes
Dec 11, 2023
| @@ -98,7 +98,7 @@ public function save_query_mapping_cb( | |||
|
|
|||
| // Save/add the node ids for this query. When one of these change in the future, we can purge the query | |||
| foreach ( $runtime_nodes as $node_id ) { | |||
| $this->store_content( $node_id, $request_key ); | |||
| $this->store_content( (string) $node_id, $request_key ); | |||
There was a problem hiding this comment.
Is a changelog entry needed for this?
Co-authored-by: Joe Fusco <josephfusco@users.noreply.github.com>
Co-authored-by: Joe Fusco <josephfusco@users.noreply.github.com>
josephfusco
approved these changes
Dec 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #263