Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/product attributes upgrade #195

Conversation

kidunot89
Copy link
Member

Your checklist for this pull request

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

🚨Please review the guidelines for contributing to this repository.

  • Make sure you are making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Make sure you are requesting to pull request from a topic/feature/bugfix branch (right side). Don't pull request from your master!

What does this implement/fix? Explain your changes.

  • ProductAttribute changed from WPObjectType to WPInterface.
  • LocalProductAttribute type implmented.
  • GlobalProductAttribute type implemented.

Example Query

query {
  products(first: 20) {
    nodes {
      id
      name
      attributes {
        nodes {
          id
          attributeId
          name
          variation
          ... on LocalProductAttribute {
            scope
            options
          }
          ... on GlobalProductAttribute {
            scope
            options
            terms {
              nodes {
                name
                id
              }
            }
          }
        }
      }
    }
  }
}

Does this close any currently open issues?

#175

Any relevant logs, error output, GraphiQL screenshots, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Any other comments?

Where has this been tested?

Operating System: Linux Mint 19.2

WordPress Version: 5.3.2

@kidunot89 kidunot89 added enhancement New feature or request new types Feature adds a new type(s) labels Dec 20, 2019
@kidunot89 kidunot89 added this to the v0.3.2 milestone Dec 20, 2019
@kidunot89 kidunot89 self-assigned this Dec 20, 2019
@kidunot89 kidunot89 modified the milestones: v0.3.2, v0.4.0 Dec 20, 2019
@kidunot89 kidunot89 mentioned this pull request Jan 14, 2020
4 tasks
@kidunot89 kidunot89 changed the base branch from develop to release/v0.4.0 January 15, 2020 22:48
@kidunot89 kidunot89 force-pushed the feature/product-attributes-upgrade branch from 65694f7 to c1239d0 Compare January 16, 2020 01:27
@kidunot89 kidunot89 merged commit 60140be into wp-graphql:release/v0.4.0 Jan 16, 2020
@kidunot89 kidunot89 deleted the feature/product-attributes-upgrade branch January 16, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new types Feature adds a new type(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant