Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Improvements #235

Merged
merged 5 commits into from
Feb 20, 2020
Merged

Code Improvements #235

merged 5 commits into from
Feb 20, 2020

Conversation

renatonascalves
Copy link
Contributor

@renatonascalves renatonascalves commented Feb 14, 2020

I'm getting more familiar to the code base. Here are a few suggestions here:

  • using the correct text-domain. Lots of more places need to be updated.
  • putting the classes at the top
  • cleaning up a bit
  • improving PHPdoc to confirm correctly

Closes #240

@renatonascalves renatonascalves self-assigned this Feb 14, 2020
@@ -75,8 +72,6 @@ public static function mutate_and_get_payload() {
}

foreach ( $input['codes'] as $code ) {
// Get the coupon.
$the_coupon = new \WC_Coupon( $code );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused!

@renatonascalves
Copy link
Contributor Author

The failing tests is unrelated to this PR.

@kidunot89 kidunot89 added enhancement New feature or request wpcs Issue/Change relates to the WordPress Coding Standards labels Feb 19, 2020
@kidunot89 kidunot89 merged commit 8b7fc3e into develop Feb 20, 2020
@kidunot89 kidunot89 deleted the feature/cleaning branch February 20, 2020 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wpcs Issue/Change relates to the WordPress Coding Standards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proper PHP Documentation Standards
2 participants